Re: [AVFS] unrar support for urar module

> On 2006-02-16 11:59, Miklos Szeredi wrote:
> >> I attached a patch to make the urar module try unrar if rar failes to 
> >> execute.
> >>
> > 
> > Thanks.
> > 
> > Ralf, does this look OK to you too?
> 
> The patch itself looks good except for a little problem. av_wait_prog
> can return -EIO even if "rar" exists. This is the case when the "rar"
> exits with a return value != 0. But I think if "rar" exits with an
> error, "unrar" will probably too so get_rar_file() aborts anyway.

Yes, also it might be a good idea to cache the result (a static
variable should do fine) so that the check for 'rar' is only done
once.

Miklos


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642