Re: [AVFS] Problems with fork, Questions about avfs

Hi,

On 02/09/2005 10:19 AM, Miklos Szeredi wrote:
>>With this solution it is possible to access any local file while still
>>be able to access most virtual files (filenames in archives with the
>>magic character are not accessable but they are not accessable at all
>>without avfs on the other hand :-) ).
>>A possible solution could be the use of the stat function of the
>>corresponding avfs struct but this could slowdown the parse_path
>>operation.
> 
> 
> But only if magic char is present in path.  And anyway stat() is a
> very fast operation.  However I don't understand why you do this in
> such a complex way in parse_path(), instead of just doing the lstat()
> in av_get_ventry() to determine once and for all if the path is local
> or not.

This was my first solution. But this way it is not possible to access an
archive in a path containing the magic char (/tmp/test#/test.zip#/).
lstat fails of course but the "test#" directory will break parse_path.

> Seems OK.  One general note: you shuld follow the coding style of the
> original code:
[snip]
> I know it's hard to follow other's style but it makes readig code much
> harder if it is written in mixed style.

Good point. I will change my patch according this coding style.

Thanks for your fast reply.

Best Regards,

Ralf Hoffmann

-- 
Homepage: http://www.boomerangsworld.de
E-Mail: Ralf Hoffmann <[email protected]>
   english or german





-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click