Re: [AVFS] Problems with fork, Questions about avfs

Hi,

On 10-Feb-2005 Miklos Szeredi wrote:
>> But on the other hand I don't see any benefit from this solution.
> 
> It's simpler, which is a great benifit :)

Agreed. I implemented this and it looks like it also works. Although it
is simplier, this code does not allow for later extension to test
virtual files the same way (example: /tmp/test#/test.zip#/test#/x)
And it is not much simplier (10 lines less code ignoring comments).
I'm currently not sure which one I like more.

>> Also my code can be extented to allow for supporting files
>> containing # inside archives if the lstat of the corresponding avfs
>> struct is used (ps->mnt->avfs->lstat()?).
> 
> Inside archives the escaping will work.  I agree that escaping has
> it's drawbacks, on the other hand # is not a very often used charater
> in filenames (I know emacs and CVS use it for intrenal purposes).

My patch deactivate escaping at all (there is a ifdef ESCAPE_MAGIC to
trigger this)! It would be harder to only escape magic chars for
virtual files (/tmp/test#/test.zip#/test##/x). By extenting my solution
to use stat also for virtual file, this could be solved but from my
point of view it is acceptable not to be able to access such virtual
files.

Best Regards,

Ralf Hoffmann

-- 
Homepage: http://www.boomerangsworld.de
E-Mail: Ralf Hoffmann <[email protected]>
  english or german



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id396&op=click