Re: [PATCH] treewide: const qualify ctl_tables where applicable
"Darrick J. Wong" <[email protected]>
| Newsgroups | gmane.comp.freedesktop.xorg.drivers.intel,gmane.linux.ports.arm.kernel,gmane.linux.kernel,gmane.linux.ports.ppc64.devel,gmane.linux.ports.riscv,gmane.linux.kernel.cryptoapi,gmane.linux.kernel.openipmi,gmane.comp.video.dri.devel,gmane.linux.drivers.rdma,gmane.linux.raid,gmane.linux.scsi,gmane.linux.serial,gmane.comp.emulators.xen.devel,gmane.linux.kernel.aio.general,gmane.linux.file-systems,gmane.comp.file-systems.coda.general,gmane.linux.kernel.mm,gmane.linux.nfs,gmane.linux.kernel.io-uring,gmane.linux.kernel.bpf,gmane.linux.kernel.kexec,gmane.comp.security.apparmor,gmane.linux.kernel.lsm |
|---|---|
| Message-ID | <20250109155154.GP1306365@frogsfrogsfrogs> |
On Thu, Jan 09, 2025 at 02:16:39PM +0100, Joel Granados wrote:
> Add the const qualifier to all the ctl_tables in the tree except the
> ones in ./net dir. The "net" sysctl code is special as it modifies the
> arrays before passing it on to the registration function.
>
> Constifying ctl_table structs will prevent the modification of
> proc_handler function pointers as the arrays would reside in .rodata.
> This is made possible after commit 78eb4ea25cd5 ("sysctl: treewide:
> constify the ctl_table argument of proc_handlers") constified all the
> proc_handlers.
Sounds like a good idea,
Reviewed-by: "Darrick J. Wong" <[email protected]> # xfs
--D