[PATCH v1 0/9] Fixes multiple sysctl bound checks
| Newsgroups | gmane.linux.drivers.rdma,gmane.linux.kernel,gmane.linux.scsi,gmane.comp.file-systems.coda.general,gmane.linux.nfs,gmane.linux.network,gmane.comp.security.firewalls.netfilter.devel |
|---|---|
| Message-ID | <[email protected]> |
From: Nicolas Bouchinet <[email protected]> Hi, This patchset adds some bound checks to sysctls to avoid negative value writes. The patched sysctls were storing the result of the proc_dointvec proc_handler into an unsigned int data. proc_dointvec being able to parse negative value, and it return value being a signed int, this could lead to undefined behaviors. This has led to kernel crash in the past as described in commit 3b3376f222e3 ("sysctl.c: fix underflow value setting risk in vm_table") Most of them are now bounded between SYSCTL_ZERO and SYSCTL_INT_MAX. nf_conntrack_expect_max is bounded between SYSCTL_ONE and SYSCTL_INT_MAX as defined by its documentation. This patchset has been written over sysctl-testing branch [1]. See [2] for similar sysctl fixes currently in review. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-testing [2]: https://lore.kernel.org/all/20250115132211.25400-1-nicolas.bouchinet-eo0qJZqvLYFAfugRpC6u6w@public.gmane.org/ Best regards, Nicolas --- Nicolas Bouchinet (9): sysctl: Fixes nf_conntrack_max bounds sysctl: Fixes nf_conntrack_expect_max bounds sysctl: Fixes gc_thresh bounds sysctl: Fixes idmap_cache_timeout bounds sysctl: Fixes nsm_local_state bounds sysctl/coda: Fixes timeout bounds sysctl: Fixes scsi_logging_level bounds sysctl/infiniband: Fixes infiniband sysctl bounds sysctl: Fixes max-user-freq bounds drivers/char/hpet.c | 4 +++- drivers/infiniband/core/iwcm.c | 4 +++- drivers/infiniband/core/ucma.c | 4 +++- drivers/scsi/scsi_sysctl.c | 4 +++- fs/coda/sysctl.c | 4 +++- fs/lockd/svc.c | 4 +++- fs/nfs/nfs4sysctl.c | 4 +++- net/ipv4/route.c | 4 +++- net/ipv6/route.c | 4 +++- net/ipv6/xfrm6_policy.c | 4 +++- net/netfilter/nf_conntrack_standalone.c | 12 +++++++++--- 11 files changed, 39 insertions(+), 13 deletions(-) -- 2.48.1