Re: [PATCH v2 3/6] sysctl/coda: Fixes timeout bounds

On Mon, Feb 24, 2025 at 10:58:18AM +0100, [email protected] wrote:
> From: Nicolas Bouchinet <[email protected]>
> 
> Bound coda timeout sysctl writings between SYSCTL_ZERO
> and SYSCTL_INT_MAX.
> 
> The proc_handler has thus been updated to proc_dointvec_minmax.
> 
> Signed-off-by: Nicolas Bouchinet <[email protected]>
> ---
>  fs/coda/sysctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> index 0df46f09b6cc5..d6f8206c51575 100644
> --- a/fs/coda/sysctl.c
> +++ b/fs/coda/sysctl.c
> @@ -20,7 +20,9 @@ static const struct ctl_table coda_table[] = {
>  		.data		= &coda_timeout,
I noticed that coda_timeout is an unsigned long. With that in mind I
would change it to unsigned int. It seems to be a value that can be
ranged within [0,INT_MAX]

Best
>  		.maxlen		= sizeof(int),
>  		.mode		= 0644,
> -		.proc_handler	= proc_dointvec
> +		.proc_handler	= proc_dointvec_minmax,
> +		.extra1		= SYSCTL_ZERO,
> +		.extra2		= SYSCTL_INT_MAX,
>  	},
>  	{
>  		.procname	= "hard",
> -- 
> 2.48.1
> 

-- 

Joel Granados