Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds

"Martin K. Petersen" <[email protected]> Mon, 03 Mar 2025 21:24:43 -0500

Newsgroups	gmane.linux.drivers.rdma,gmane.linux.kernel,gmane.linux.scsi,gmane.comp.file-systems.coda.general,gmane.linux.nfs
Organization	Oracle Corporation
Message-ID	<[email protected]>

Joel,

> 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
>    silently capped by proc_dointvec_minmax, but it is good to have as it
>    adds to the understanding on what the range of the values are.
>
> 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
>    prevent ppl trying to assigning negative values to the unsigned integer
>
> Let me know if you take this through the scsi subsystem so I know to
> drop it from sysctl 

Applied to 6.15/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering