Re: [PATCH v2 4/6] sysctl: Fixes scsi_logging_level bounds

Joel Granados <[email protected]>
Newsgroups gmane.linux.drivers.rdma,gmane.linux.kernel,gmane.linux.scsi,gmane.comp.file-systems.coda.general,gmane.linux.nfs
Message-ID <oy2jkeisvm7edg7zrohp6iipvnktj5o3sw5hxksoxgorppoj6r@hubn7cifqdxl>
On Mon, Mar 03, 2025 at 09:24:43PM -0500, Martin K. Petersen wrote:
> 
> Joel,
> 
> > 1. Having the upper bound be SYSCTL_INT_MAX is not necessary (as it is
> >    silently capped by proc_dointvec_minmax, but it is good to have as it
> >    adds to the understanding on what the range of the values are.
> >
> > 2. Having the lower bound capped by SYSCTL_ZERO is needed as it will
> >    prevent ppl trying to assigning negative values to the unsigned integer
> >
> > Let me know if you take this through the scsi subsystem so I know to
> > drop it from sysctl 
> 
> Applied to 6.15/scsi-staging, thanks!
Thx!!

@Nicolas: Please take this out of your next version as it is already
going upstream.

Best

> 
> -- 
> Martin K. Petersen	Oracle Linux Engineering

-- 

Joel Granados
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.