Re: [PATCH v3 01/12] vfs: widen inode hash/lookup functions to u64

Jeff Layton <[email protected]> Fri, 06 Mar 2026 07:03:15 -0500
Newsgroups gmane.linux.kernel.lsm,gmane.linux.file-systems,gmane.linux.kernel,gmane.linux.kernel.mm,gmane.comp.file-systems.ext4,gmane.linux.file-systems.f2fs,gmane.linux.nfs,gmane.linux.kernel.cifs,gmane.network.samba.internals,gmane.comp.file-systems.nilfs.user,gmane.linux.kernel.autofs,gmane.comp.file-systems.ceph.devel,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.ecryptfs.general,gmane.linux.drivers.mtd,gmane.linux.file-systems.union,gmane.comp.security.apparmor,gmane.comp.freedesktop.amd-gfx,gmane.comp.video.dri.devel,gmane.linux.drivers.video-input-infrastructure,gmane.linux.network,gmane.linux.kernel.perf.user,gmane.linux.hams,gmane.linux.x25,gmane.linux.bluez.kernel,gmane.linux.can,gmane.linux.kernel.bpf
Message-ID <[email protected]> 
On Thu, 2026-03-05 at 06:24 -0800, Christoph Hellwig wrote:
> > =C2=A0extern struct inode *ilookup5_nowait(struct super_block *sb,
> > -		unsigned long hashval, int (*test)(struct inode *, void *),
> > +		u64 hashval, int (*test)(struct inode *, void *),
> > =C2=A0		void *data, bool *isnew);
> > -extern struct inode *ilookup5(struct super_block *sb, unsigned long ha=
shval,
> > +extern struct inode *ilookup5(struct super_block *sb, u64 hashval,
> > =C2=A0		int (*test)(struct inode *, void *), void *data);
>=20
> ...
>=20
> Can you please drop all these pointless externs while you're at it?
>=20

I was planning to do that, but then Christian merged it!

I'll do a patch on top of this that does this in the range of fs.h that
the patch touches. Christian can throw it on top of the series, and
that shouldn't be too bad for backports.

> Otherwise looks good:
>=20
> Reviewed-by: Christoph Hellwig <[email protected]>

Thanks for the review!
--=20
Jeff Layton <[email protected]>