Re: [RFC 2/4] ext3 blocks: ext3_new_blocks() prepare work

On Fri, 2006-05-19 at 11:59 +0100, Stephen C. Tweedie wrote:
> Hi,
> 
> On Thu, 2006-05-18 at 17:57 -0700, Mingming Cao wrote:
> 
> > Checked through the whole ext3 code, found a couple of other places has
> > the same issue.  A incremental patch for this:
> 
> Thanks!
> 
> Every single one of these, without exception, is doing 
> 
> 	s_first_data_block + (group * BLOCKS_PER_GROUP)
> 
> with potentially another block offset being added in depending on the
> case.
> 
> This tells me that we need an ext3_group_start(group) function (it's
> simple enough that it could be a static inline) to abstract it out and
> get it right in just the one place!
> 

Fair enough, added it to my todo list.

Thanks,
Mingming




-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642