Re: [PATCH] sector_t overflow in block layer
Pavel Machek <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Hi! > > Why isn't that just a > > > > if (unlikely(sector != (sector_t)sector)) > > > > and that's it? What does this have to do with CONFIG_LBD or BITS_PER_LONG, > > or anything at all? > > > > If the sector number fits in a sector_t, we're all good. > > I think you missed that Andrewas said he is worried about 64-bit overflows > as well. And you would not catch those with the sector != Can 64-bit really overflow? That's 16 000 Peta bytes, AFAICS. Does anyone really have disk array over 100 Peta bytes? How much space does Google have, for example? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642