Re: [PATCH] Fix ext2_fs_sb.h for user space

On Thursday 08 June 2006 17:29, Theodore Tso wrote:
> On Wed, Jun 07, 2006 at 10:48:48PM +0200, Thomas Koeller wrote:
> > This patch modifies the EXT2 superblock header file
> > so that it can be included by user-space programs.
>
> Um, which user-space program is needing this data structure?  You do
> realize that (a) this data structure is not guaranteed to be constant
> across kernel versions, and (b) has little or nothing to do with the
> on-disk superblock layout?
>
> User-space programs should be using the ext2 libraries and header
> files which are shipped with e2fsprogs.
>
> 						- Ted

I had accidentally deleted some important files and, in an attempt
to recover these, tried to build the 'undelete' program by
Sebastian Hetze <[email protected]>.

Quote from the 'INSTALL' file that comes with this package:
"undelete heavily depends on the ext2 libraries provided by Theodore
Ts'o with the e2fsprogs package." However, the source includes
ext2_fs_sb.h, and in order to be able to build this program I
created the patch I submitted.

Thomas
-- 
Thomas Koeller
[email protected]