Re: [RFC 1/2] ext3: enlarge blocksize and fix rec_len overflow

Hi Takashi,

> ext2/ext3_dir_entry_2 has a 16-bit entry(rec_len) and it would overflow
> with 64KB blocksize.  This patch prevent from overflow by limiting
> rec_len to 65532.

In empty_dir(), offset is incremented by de->rec_len until it reaches
inode->i_size. I think bad things will happen with a 64kB blocksize since
the records no longer span the entire directory block.

AFAICS, there's a similar issue with bh->b_size in ext3_delete_entry().

Cheers,

Johann

Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642