[RFC][Update][Patch 12/16]Fix undefined ">> 32" in revoke code
Mingming Cao <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel,gmane.linux.kernel,gmane.linux.file-systems |
|---|---|
| Organization | IBM LTC |
| Message-ID | <[email protected]> |
"val >> 32" is undefined if val is a 32-bit value, so this code is broken if CONFIG_LBD is not set. Make it safe for that case. Signed-off-by: Stephen Tweedie <[email protected]> Signed-off-by: Mingming Cao <[email protected]> --- linux-2.6.17-ming/fs/jbd/revoke.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN fs/jbd/revoke.c~jbd-revoke-32bit-shift-fix fs/jbd/revoke.c --- linux-2.6.17/fs/jbd/revoke.c~jbd-revoke-32bit-shift-fix 2006-06-28 16:47:09.695458913 -0700 +++ linux-2.6.17-ming/fs/jbd/revoke.c 2006-06-28 16:47:09.699458454 -0700 @@ -110,7 +110,7 @@ static inline int hash(journal_t *journa { struct jbd_revoke_table_s *table = journal->j_revoke; int hash_shift = table->hash_shift; - int hash = (int)block ^ (int)(block >> 32); + int hash = (int)block ^ (int)((block >> 31) >> 1); return ((hash << (hash_shift - 6)) ^ (hash >> 13) ^ _ Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642