Re: [RFC][PATCH]add ext3_fileblk_t for file relative offset

On Jun 28, 2006  22:31 +0900, [email protected] wrote:
> In Mingming's patch set, the single type `ext3_fsblk_t' deal with two
> different values, which are file relative offset and filesystem
> relative offset.  I think it is confusing.
> 
> Therefore I added "ext3_fileblk_t" for file relative offset.
> It makes maintenance easier and code clearer if file size
> needs to be larger.
> ext3_fileblk_t is unsigned long which is the maximum size of
> current type for file relative offset.

I think this is a good idea and support its inclusion into the patch set.
It also managed to find one (harmless) bug in the code.
 
>  int ext3_get_blocks_handle(handle_t *handle, struct inode *inode,
> -		sector_t iblock, unsigned long maxblocks,
> +		ext3_fileblk_t iblock, unsigned long maxblocks,

iblock shouldn't have been a sector_t.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.


Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642