different tune2fs -e continue behavior in 2.4 vs. 2.6?

Eric Sandeen <[email protected]>
Newsgroups gmane.comp.file-systems.ext2.devel
Message-ID <[email protected]>
It looks like it's been this way for a long time, but in 2.4, 
ext3_handle_error() does -not- abort the journal if "continue" (tune2fs -e 
continue / EXT3_ERRORS_CONTINUE) is specified.  In 2.6, "continue" behavior 
-does- shut down the journal:

         if (test_opt (sb, ERRORS_RO)) {
                 printk (KERN_CRIT "Remounting filesystem read-only\n");
                 sb->s_flags |= MS_RDONLY;
         } else {
                 journal_t *journal = EXT3_SB(sb)->s_journal;

                 EXT3_SB(sb)->s_mount_opt |= EXT3_MOUNT_ABORT;
                 if (journal)
                         journal_abort(journal, -EIO);
         }

Which behavior is intended?  (shutting down the journal seems like odd behavior 
when the man page describes "continue" as "Continue normal operation."

Thanks,

-Eric

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.