Re: [BLOCK] bh: Ensure bh fits within a page
Andrew Morton <[email protected]>
| Newsgroups | gmane.comp.file-systems.ext2.devel,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 1 Aug 2006 15:02:59 +1000 Herbert Xu <[email protected]> wrote: > On Mon, Jul 31, 2006 at 09:04:18PM -0700, Andrew Morton wrote: > > > > Could we have a more detailed description? > > Sure, this particular instance is in journal_write_metadata_buffer > where the bh may be constructed from kmalloc memory (search for the > call to jbd_rep_kmalloc). Because the memory returned by kmalloc > may straddle a page (when slab debugging is enabled that is), this > causes a broken bh to be injected into submit_bh. > Crap, that's hard to fix. Am I allowed to blame submit_bh()? ;) uhm, we don't want to lose kmalloc redzoning, so I guess we need to create on-demand ext3-private slab caches for 1024, 2048, and 4096 bytes. With the appropriate slab flags to defeat the redzoning. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV