Re: [PATCH] 08/13 e2fsprogs-extents_visible - make extents visible to lsattr

On Wed, Aug 02, 2006 at 10:57:37AM -0600, Andreas Dilger wrote:
> Make extent-mapped files visible to lsattr.

Note: in order to make things consistent, and in the long-run less
confusing, I renamed EXT3_EXTENTS_FL to EXT4_EXTENTS_FL, since given
the LKML discussion extents will only be an ext4 thing.  This cause
patch #9 tonot apply cleanly, but that's relatively easy to fix up.

I suggest we make a s similar change to the kernel patches before we
submit them upstream.

						- Ted

# HG changeset patch
# User [email protected]
# Date 1154818222 14400
# Node ID 1a8cf199f21a5191c98ad6ce9cdd7df0edd738e0
# Parent  d67dde7a3c861b8092dbd8f7811039192a88ec36
Rename EXT3_EXTENTS_FL to EXT4_EXTENTS_FL and make it visible to the user

lsattr will display the EXT4_EXTENTS_FL flag

Signed-off-by: Andreas Dilger <[email protected]>
Signed-off-by: "Theodore Ts'o" <[email protected]>

diff -r d67dde7a3c86 -r 1a8cf199f21a lib/e2p/ChangeLog
--- a/lib/e2p/ChangeLog	Sat Aug 05 14:41:00 2006 -0400
+++ b/lib/e2p/ChangeLog	Sat Aug 05 18:50:22 2006 -0400
@@ -1,3 +1,7 @@ 2006-05-08  Theodore Tso  <[email protected]
+2006-08-05  Theodore Tso  <[email protected]>
+
+	* pf.c: Add support for EXT4_EXTENTS_FL flag.
+
 2006-05-08  Theodore Tso  <[email protected]>
 
 	* feature.c: Add support for EXT2_FEATURE_COMPAT_LAZY_BG feature.
diff -r d67dde7a3c86 -r 1a8cf199f21a lib/e2p/pf.c
--- a/lib/e2p/pf.c	Sat Aug 05 14:41:00 2006 -0400
+++ b/lib/e2p/pf.c	Sat Aug 05 18:50:22 2006 -0400
@@ -44,6 +44,7 @@ static struct flags_name flags_array[] =
 	{ EXT2_INDEX_FL, "I", "Indexed_direcctory" }, 
 	{ EXT2_NOTAIL_FL, "t", "No_Tailmerging" },
 	{ EXT2_TOPDIR_FL, "T", "Top_of_Directory_Hierarchies" },
+	{ EXT4_EXTENTS_FL, "e", "Extents" },
 	{ 0, NULL, NULL }
 };
 
diff -r d67dde7a3c86 -r 1a8cf199f21a lib/ext2fs/ChangeLog
--- a/lib/ext2fs/ChangeLog	Sat Aug 05 14:41:00 2006 -0400
+++ b/lib/ext2fs/ChangeLog	Sat Aug 05 18:50:22 2006 -0400
@@ -1,3 +1,9 @@ 2006-07-15  Theodore Tso  <[email protected]
+2006-08-05  Theodore Tso  <[email protected]>
+
+	* ext2_fs.h (EXT4_EXTENTS_FL): Rename EXT3_EXTENTS_FL to
+		EXT4_EXTENTS_FL, and add EXT4_EXTENTS_FL to user visible
+		flags list.
+
 2006-07-15  Theodore Tso  <[email protected]>
 
 	* ext2fs.h: Remove unneeded #ifdef since EXT2_DYNAMIC_REV is
diff -r d67dde7a3c86 -r 1a8cf199f21a lib/ext2fs/ext2_fs.h
--- a/lib/ext2fs/ext2_fs.h	Sat Aug 05 14:41:00 2006 -0400
+++ b/lib/ext2fs/ext2_fs.h	Sat Aug 05 18:50:22 2006 -0400
@@ -236,10 +236,10 @@ struct ext2_dx_countlimit {
 #define EXT2_NOTAIL_FL			0x00008000 /* file tail should not be merged */
 #define EXT2_DIRSYNC_FL 		0x00010000 /* Synchronous directory modifications */
 #define EXT2_TOPDIR_FL			0x00020000 /* Top of directory hierarchies*/
-#define EXT3_EXTENTS_FL 		0x00080000 /* Inode uses extents */
+#define EXT4_EXTENTS_FL 		0x00080000 /* Inode uses extents */
 #define EXT2_RESERVED_FL		0x80000000 /* reserved for ext2 lib */
 
-#define EXT2_FL_USER_VISIBLE		0x0003DFFF /* User visible flags */
+#define EXT2_FL_USER_VISIBLE		0x000BDFFF /* User visible flags */
 #define EXT2_FL_USER_MODIFIABLE		0x000080FF /* User modifiable flags */
 
 /*
diff -r d67dde7a3c86 -r 1a8cf199f21a misc/ChangeLog
--- a/misc/ChangeLog	Sat Aug 05 14:41:00 2006 -0400
+++ b/misc/ChangeLog	Sat Aug 05 18:50:22 2006 -0400
@@ -1,3 +1,7 @@ 2006-07-15  Theodore Tso  <[email protected]
+2006-08-05  Theodore Tso  <[email protected]>
+
+	* filefrag.c: Change EXT3_EXTENTS_FL to EXT4_EXTENTS_FL
+
 2006-07-15  Theodore Tso  <[email protected]>
 
 	* mke2fs.c (PRS): Look up the default inode size in the
diff -r d67dde7a3c86 -r 1a8cf199f21a misc/filefrag.c
--- a/misc/filefrag.c	Sat Aug 05 14:41:00 2006 -0400
+++ b/misc/filefrag.c	Sat Aug 05 18:50:22 2006 -0400
@@ -44,7 +44,7 @@ int verbose = 0;
 #define FIBMAP	   _IO(0x00,1)	/* bmap access */
 #define FIGETBSZ   _IO(0x00,2)	/* get the block size used for bmap */
 
-#define EXT3_EXTENTS_FL			0x00080000 /* Inode uses extents */
+#define EXT4_EXTENTS_FL			0x00080000 /* Inode uses extents */
 #define	EXT3_IOC_GETFLAGS		_IOR('f', 1, long)
 
 static unsigned long get_bmap(int fd, unsigned long block)
@@ -126,7 +126,7 @@ static void frag_report(const char *file
 	}
 	if (ioctl(fd, EXT3_IOC_GETFLAGS, &flags) < 0)
 		flags = 0;
-	if (flags & EXT3_EXTENTS_FL) {
+	if (flags & EXT4_EXTENTS_FL) {
 		printf("File is stored in extents format\n");
 		is_ext2 = 0;
 	}

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV