Re: [PATCH 1/9] extents for ext4

On Thu, 10 Aug 2006 13:17:55 -0400
Theodore Tso <[email protected]> wrote:

> On Wed, Aug 09, 2006 at 11:39:40PM -0700, Andrew Morton wrote:
> > - replace all brelse() calls with put_bh().  Because brelse() is
> >   old-fashioned, has a weird name and neelessly permits a NULL arg.
> > 
> >   In fact it would be beter to convert JBD and ext3 to put_bh before
> >   copying it all over.
> 
> Wouldn't it be better to preserve in the source code history the
> brelse->put_bh conversion?  We can pour a huge number of changes in
> ext4 before we submit, but I would have thought it would be easier for
> everyone to see what is going on if we submit with just the minimal
> changes, and then have patches that address concerns like this one at
> a time.
> 

I'd suggest that this be one of the cleanups which be done within ext3
before taking the ext4 copy.

That's assuming we want to do the spring-cleaning - we might of course
decide not to.  But it'd be a good time to do so.

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642