Re: Should block-number-in-file vars be using blkcnt_t?

Takashi Sato wrote:

> I have reviewed your patch.
> I think your patch is correct except returning EPERM as above.
> 
> Eric Sandeen wrote:
>> But as the filesystem gets bigger, can't we fit more inodes in,
>> potentially overflowing 31 bits?  I guess I need to go look at the
>> ratios and mkfs thresholds again ...
>>
>> Hmm but you're right, I have not audited inode number containers in
>> general...
> 
> My patches(*1) already support >2^31 inode number.
> I hope it is useful for you.

Thanks!  I'm also going over your original patchset (now that I know that it 
exists.... sorry about that...) and I'll send some comments tomorrow.  I think 
I've found a few more format string changes & overflows that can be addressed.

Hopefully we'll get these all upstream some day... :)

Thanks,

-Eric

> *1: "extend file size and filesystem size" on May 5
> 
> Cheers, Takashi


-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642