Re: ext3_dx_add_entry: Directory index full!

David Woodhouse <[email protected]> Sun, 18 May 2008 16:39:39 +0100

Newsgroups	gmane.linux.kernel,gmane.comp.file-systems.ext3.user,gmane.comp.file-systems.ext2.devel
Message-ID	<[email protected]>

On Sun, 2008-05-18 at 17:36 +0200, Bernie Innocenti wrote:
> 
> 
>   static inline unsigned dx_root_limit (struct inode *dir, unsigned
> infosize)
>   {
>       unsigned entry_space = dir->i_sb->s_blocksize -
> EXT3_DIR_REC_LEN(1) -
>           EXT3_DIR_REC_LEN(2) - infosize;
>       return 0? 20: entry_space / sizeof(struct dx_entry);
>   }
> 
> Am I reading the above code correctly?  Why does it always return
> 20 no matter what?

It doesn't. "condition?A:B" will return A if the condition is _true_,
which it isn't.

-- 
dwmw2