RE: [SPAM] Memory leak in izo_upc_upcall() ?
"=?ks_c_5601-1987?B?seggtb+/7Q==?=" <[email protected]> Tue, 7 Oct 2003 11:05:55 +0900
| Newsgroups | gmane.comp.file-systems.intermezzo.devel |
|---|---|
| Message-ID | <[email protected]> |
Yes, we know that the req->rq_data is a pointer to the input parameter to the izo_upc_upcall(). But the parameter was alloc'ed using PRESTO_ALLOC() in the caller functions like izo_upc_permit(). So we need to free the parameter using PRESTO_FREE(), don't we ? -----Original Message----- From: [email protected] [mailto:intermezzo- [email protected]] On Behalf Of Yang, Chen Sent: Tuesday, October 07, 2003 1:35 AM To: =B1=E8 =B5=BF=BF=ED Cc: [email protected] Subject: Re: [SPAM] Memory leak in izo_upc_upcall() ? Hi, This should not cause memory leakage. Only those called presto_alloc routines should call presto_free routine to free the memory. From the routine, we can see that req->rq_data is just a pointer to the parameter passed in. So it should not be free-ed. If there is something wrong, please correct me.Thanks. -- Yang, Chen > Hi, I=A1=AFve tried the new version 1.42 2003/09/30 of intermezzo > and I think there=A1=AFs a memory leak at the near of the end the > izo_upc_upcall(). > > ... > exit_req: > PRESTO_FREE(req->rq_data, req->rq_bufsiz); // I think this line is > missing. > PRESTO_FREE(req, sizeof(struct upc_req)); > exit_buf: > return error; > } > > > ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ intermezzo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/intermezzo-devel ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf