Re: [PATCH] remove TCGETS

> 1. Make my file system return -ENOTTY.
> 2. Make LTP accept -EINVAL instead of -ENOTTY on an invalid ioctl.
> 3. Make LTP accept _either_ -EINVAL or -ENOTTY in that case.

I believe there is another choice (but I'm guessing a little at when LTP 
does):

4. Make my file system return -ENOTTY to terminal ioctls, and -EINVAL to 
everything else.

That's what _I_ ended up doing.

It seems gross because an ioctl handler for a regular file shouldn't have 
to know what a terminal ioctl is.  But this problem stems from the ancient 
view of ioctls that there is a single universal name space of ioctl 
commands and every ioctl command means something to everyone, even if it 
may be inapplicable in a particular instance.  I don't think that view 
ever made it beyond terminal ioctls, though.

--
Bryan Henderson                          IBM Almaden Research Center
San Jose CA                              Filesystems

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html