Re: [PATCH] remove TCGETS

On Tue, Oct 28, 2003 at 01:07:53PM -0800, Linus Torvalds wrote:
> 
> On Tue, 28 Oct 2003, David Woodhouse wrote:
> >
> > Linus; executive decision required please:
> 
> I don't know you you _require_ an executive decision, but the simple fact 
> is that the regular Linux ioctl() handler always returns ENOTTY if it 
> doesn't match a ioctl number. See fs/ioctl.c.
> 
> In short, the way I think this should be handled is:
>  - if you don't recognize the ioctl, you should return ENOTTY
>  - if you recognize the ioctl, but some parameter to the ioctl is wrong, 
>    you should return EINVAL.
> 
> This is consistent with file_ioctl(), and also consistent with traditional
> uses of ENOTTY. It also just happens to make LTP pass, but I will leave to
> you to make up your own mind on whether that is because LTP is a good
> test, or whether it's just a small unimportant detail.

Can't we add the range of tty ioctls to file_ioctl so that it can return
ENOTTY so each and every file system driver doesn't have to?

a

-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html