Re: [PATCH] some memory leaks for intermezzo module (2.4 kernel)

Hi, Renaud:
    Thanks for your patch.I will check it and  commit into the Inter-Mezzo
source code.
    In fact, I have traced it for some time. Different to your solution, I
used the presto_dentry_slab allocator to free the dangle structure
explicitly in presto_file_release method. In my memory, there slab
allocator will fail to free 2 structures after rmmod, which will cause
the second insmod OOPS.
--
    Yang, Chen

> Hello,
>
> +this patch essentially resolve a slab allocator problem, which prevent
> unloading of the intermezzo.o module.
>
> While digging in intermezzo source, I saw that some dentries have
> presto_dentry_data allocated , but d_op  not redirected to
> presto_d_release.
> By the way these data are never freed to the slab allocator.
> As a result, intermezzo module can't be reloaded, because of
> kmem_cache_destroy unable to destroy the presto_cache.
>
> To fix this , I moved the d_op redirection closest to allocation of the
> d_data, in the presto_set_dd function. IMHO, this is a far better place
>
> To be precise, the defective dentry was :
> /mountpoint_of_my_intermezzo_fs/.intermezzo/config
> used by Intersync.
> In fact, all files created just under .intermezzo (and not in
> subdirectories) are affected.
>
> + fix some memory leaks and presto_kmemory false counts.
> + backport of Domen Puncer and Chen Yang replicator.c correction
>
>
>
> --
> Renaud Duhaut <[email protected]>
>



-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/01