[PATCH 09/13] jfs: Use list_add_(before|after) macros
Ken Helias <[email protected]>
| Newsgroups | gmane.comp.file-systems.jfs.general |
|---|---|
| Message-ID | <1402076072-4044-9-git-send-email-kenhelias__8047.81286647103$1402089682$gmane$org@web.de> |
From: Ken Helias <[email protected]> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <[email protected]> Cc: [email protected] --- fs/jfs/jfs_dmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/jfs/jfs_dmap.c b/fs/jfs/jfs_dmap.c index 2d514c7..d08c6d6 100644 --- a/fs/jfs/jfs_dmap.c +++ b/fs/jfs/jfs_dmap.c @@ -560,7 +560,7 @@ dbUpdatePMap(struct inode *ipbmap, /* insert bp after tblock in logsync list */ log->count++; - list_add(&mp->synclist, &tblk->synclist); + list_add_after(&mp->synclist, &tblk->synclist); mp->clsn = tblk->clsn; } -- 2.0.0 ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech