Re: [PATCH 19/22] jfs: %pF is only for function pointers

On 03/11/2015 10:13 PM, Scott Wood wrote:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
> 
> Signed-off-by: Scott Wood <[email protected]>
> Cc: [email protected]
Acked-by: Dave Kleikamp <[email protected]>

Do you intend to submit these as a set, or would you rather I push this
one through the jfs subsystem?

Thanks,
Shaggy

> ---
>  fs/jfs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/super.c b/fs/jfs/super.c
> index 5d30c56..4cd9798 100644
> --- a/fs/jfs/super.c
> +++ b/fs/jfs/super.c
> @@ -102,7 +102,7 @@ void jfs_error(struct super_block *sb, const char *fmt, ...)
>  	vaf.fmt = fmt;
>  	vaf.va = &args;
>  
> -	pr_err("ERROR: (device %s): %pf: %pV\n",
> +	pr_err("ERROR: (device %s): %ps: %pV\n",
>  	       sb->s_id, __builtin_return_address(0), &vaf);
>  
>  	va_end(args);
> 

------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net/