Re: [PATCH] fs: cleanup slight list_entry abuse
Dave Kleikamp <[email protected]>
| Newsgroups | gmane.comp.file-systems.jfs.general,gmane.comp.file-systems.coda.general,gmane.linux.file-systems.ntfs.devel,gmane.linux.kernel,gmane.linux.drivers.mtd,gmane.linux.file-systems |
|---|---|
| Message-ID | <[email protected]> |
On 03/19/2015 11:11 AM, Boaz Harrosh wrote: > On 03/19/2015 01:28 PM, Rasmus Villemoes wrote: >> list_entry is just a wrapper for container_of, but it is arguably >> wrong (and slightly confusing) to use it when the pointed-to struct >> member is not a struct list_head. Use container_of directly instead. >> >> Signed-off-by: Rasmus Villemoes <[email protected]> >> --- >> Most of these predate git. If I'm the only one who has been confused >> by this in 10 years, maybe it's not worth the churn. >> > > No you are not alone here. I have seen this once as well but did not have > the gumption to send a fix. (The sysv.h one) > > I totally agree with this patch. (So many of them, bread crumbs of copy/paste > for you ;0) I'm sure that was the case with jfs. > > Reviewed-by: Boaz Harrosh <[email protected]> Acked-by: Dave Kleikamp <[email protected]> ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/