Re: [PATCH 04/40] proc: introduce proc_create_seq{, _data}

David Howells <[email protected]> Mon, 30 Apr 2018 14:19:25 +0100
Newsgroups gmane.comp.file-systems.jfs.general
Organization Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
Message-ID <26540.1525094365__27827.2446514622$1525094281$gmane$org@warthog.procyon.org.uk>
Christoph Hellwig <[email protected]> wrote:

> +
> +struct proc_dir_entry *proc_create_seq_data(const char *name, umode_t mode,
> +		struct proc_dir_entry *parent, const struct seq_operations *ops,
> +		void *data)
> +{
> ...
> +EXPORT_SYMBOL(proc_create_seq_data);

Please add documentation comments to exported functions when you add them.

David

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot