[PATCH 5/5] orangefs: cache NULL when both default_acl and acl are NULL
Chengguang Xu <[email protected]> Tue, 14 Aug 2018 22:16:34 +0800
| Newsgroups | gmane.comp.file-systems.jfs.general |
|---|---|
| Message-ID | <20180814141634.5471-5-cgxu519__96.6499014340982$1534257515$gmane$org@gmx.com> |
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu <[email protected]> --- fs/orangefs/acl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c index 10587413b20e..e3b043a263bc 100644 --- a/fs/orangefs/acl.c +++ b/fs/orangefs/acl.c @@ -175,6 +175,9 @@ int orangefs_init_acl(struct inode *inode, struct inode *dir) posix_acl_release(acl); } + if (!default_acl && !acl) + cache_no_acl(inode); + /* If mode of the inode was changed, then do a forcible ->setattr */ if (mode != inode->i_mode) { memset(&iattr, 0, sizeof iattr); -- 2.17.1 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot