Re: [PATCH] jfs: fix comment in struct jfs_superblock

On 11/7/18 9:29 PM, Shenghui Wang wrote:
> sizeof(struct jfs_superblock) is 184 bytes, and offset of
> 's_xlogpxd' in struct jfs_superblock is 128 bytes.
> Move the comment "/* - 128 byte boundary - */" ahead of
> 's_xlogpxd'.

Thanks. I think it would be better to just remove the "128 byte
boundary" comment altogether. It's always been wrong and it really isn't
helpful.

Thanks,
Dave

> 
> Signed-off-by: Shenghui Wang <[email protected]>
> ---
>  fs/jfs/jfs_superblock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/jfs_superblock.h b/fs/jfs/jfs_superblock.h
> index 04847b8d3070..546a109349df 100644
> --- a/fs/jfs/jfs_superblock.h
> +++ b/fs/jfs/jfs_superblock.h
> @@ -97,8 +97,8 @@ struct jfs_superblock {
>  	/* extendfs() parameter under s_state & FM_EXTENDFS */
>  	__le64 s_xsize;		/* 8: extendfs s_size */
>  	pxd_t s_xfsckpxd;	/* 8: extendfs fsckpxd */
> -	pxd_t s_xlogpxd;	/* 8: extendfs logpxd */
>  	/* - 128 byte boundary - */
> +	pxd_t s_xlogpxd;	/* 8: extendfs logpxd */
>  
>  	char s_uuid[16];	/* 16: 128-bit uuid for volume */
>  	char s_label[16];	/* 16: volume label */
>