Re: [PATCH] jfs: compare old and new mode before setting update_mode flag

Sorry for ignoring this for so long. It looks good. I'll push it upstream.

Thanks,
Shaggy

On 11/24/18 3:40 AM, Chengguang Xu wrote:
> If new mode is the same as old mode we don't have to reset
> inode mode in the rest of the code, so compare old and new
> mode before setting update_mode flag.
> 
> Signed-off-by: Chengguang Xu <[email protected]>
Signed-off-by: Dave Kleikamp <[email protected]>
> ---
>  fs/jfs/acl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c
> index 8c06a6ea862d..ebb299003a5b 100644
> --- a/fs/jfs/acl.c
> +++ b/fs/jfs/acl.c
> @@ -117,7 +117,8 @@ int jfs_set_acl(struct inode *inode, struct posix_acl *acl, int type)
>  		rc = posix_acl_update_mode(inode, &mode, &acl);
>  		if (rc)
>  			goto end_tx;
> -		update_mode = 1;
> +		if (mode != inode->i_mode)
> +			update_mode = 1;
>  	}
>  	rc = __jfs_set_acl(tid, inode, type, acl);
>  	if (!rc) {
>