Re: [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

James Morris <[email protected]> Fri, 16 Aug 2019 08:27:07 +1000 (AEST)
Newsgroups gmane.comp.file-systems.jfs.general
Message-ID <alpine.LRH.2.21.1908160825310.22623__34000.1647755102$1565908721$gmane$org@namei.org>
On Thu, 15 Aug 2019, Mark Salyzyn wrote:

> Good Idea, but using the same argument structure for set and get I would be
> concerned about the loss of compiler protection for the buffer argument;

Agreed, I missed that.

> struct getxattr_args {
> 	struct dentry *dentry;
> 	struct inode *inode;
> 	const char *name;
> 	void *buffer;
> 	size_t size;
> 	int flags;

Does 'get' need flags?

-- 
James Morris
<[email protected]>