Re: [PATCH] (ext) inode attributes for jfs

On Wed, 2006-02-01 at 11:29 +0100, Herbert Poetzl wrote:
> Hi Dave!
> 
> sorry for following up on my own email instead
> of your reply, but I'm not subscribed to the
> jfs mailing list, and the archive does not contain
> (or show?) headers so that I could 'fake' a reply
> 
> anyway, here are some thoughts about the attributes
> and a patch to look at ...

It looks good.  I only have one question (or two questions that are
basically the same):

> diff -NurpP --minimal linux-2.6.16-rc1/fs/jfs/jfs_dinode.h linux-2.6.16-rc1-jfs/fs/jfs/jfs_dinode.h
> --- linux-2.6.16-rc1/fs/jfs/jfs_dinode.h	2004-12-25 01:55:20 +0100
> +++ linux-2.6.16-rc1-jfs/fs/jfs/jfs_dinode.h	2006-02-01 09:51:16 +0100
> @@ -139,13 +139,36 @@ struct dinode {
>  
>  /* more extended mode bits: attributes for OS/2 */
>  #define IREADONLY	0x02000000	/* no write access to file */
> -#define IARCHIVE	0x40000000	/* file archive bit */
> -#define ISYSTEM		0x08000000	/* system file */
>  #define IHIDDEN		0x04000000	/* hidden file */
> -#define IRASH		0x4E000000	/* mask for changeable attributes */
> -#define INEWNAME	0x80000000	/* non-8.3 filename format */
> +#define ISYSTEM		0x08000000	/* system file */
> +
>  #define IDIRECTORY	0x20000000	/* directory (shadow of real bit) */
> +#define IARCHIVE	0x40000000	/* file archive bit */
> +#define INEWNAME	0x80000000	/* non-8.3 filename format */
> +
> +#define IRASH		0x4E000000	/* mask for changeable attributes */
>  #define ATTRSHIFT	25	/* bits to shift to move attribute
>  				   specification to mode position */
>  
> +/* extended attributes for Linux */
> +
> +#define JFS_NOATIME_FL		0x00080000 /* do not update atime */
> +
> +#define JFS_DIRSYNC_FL		0x00100000 /* dirsync behaviour */
> +#define JFS_SYNC_FL		0x00200000 /* Synchronous updates */
> +#define JFS_SECRM_FL		0x00400000 /* Secure deletion */
> +#define JFS_UNRM_FL		0x00800000 /* allow for undelete */
> +
> +#define JFS_APPEND_FL		0x01000000 /* writes to file may only append */
> +#define JFS_IMMUTABLE_FL	0x02000000 /* Immutable file */
> +
> +#define JFS_FL_USER_VISIBLE	0x0FF80000
why not 0x03f80000?  ISYSTEM & IHIDDEN are not mapped to ext2 flags, so
they will get lost by jfs_map() anyway, right?

> +#define JFS_FL_USER_MODIFIABLE	0x03F80000
> +#define JFS_FL_INHERIT		0x0BC80000
Any reason that you included ISYSTEM in the JFS_FL_INHERIT flags?

> +
> +
> +#define JFS_IOC_GETFLAGS	_IOR('f', 1, long)
> +#define JFS_IOC_SETFLAGS	_IOW('f', 2, long)
> +
> +
>  #endif /*_H_JFS_DINODE */
-- 
David Kleikamp
IBM Linux Technology Center



-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642