Re: [PATCH] makefile fix, change installer compression

Joe:

Which version of nmake are you using?
The 1.3.63 release of openAFS was built using MSVC 6.0

    [C:\4\4NT]nmake -version   
    Microsoft (R) Program Maintenance Utility   Version 6.00.8168.0

and it had no problems.  What errors have you seen?

---

I will commit the installer change.

Jeffrey Altman


Joe Buehler wrote:

> The nmake I have (MSVC 6) does not like client_creds/NTMakefile as is,
> I suspect there are some typos.
>
> Using lzma compression in the installer reduces the installer size by
> a couple megabytes.
>
> Index: src/WINNT/client_creds/NTMakefile
> ===================================================================
> RCS file: /cvs/openafs/src/WINNT/client_creds/NTMakefile,v
> retrieving revision 1.9
> diff -u -r1.9 NTMakefile
> --- src/WINNT/client_creds/NTMakefile    1 Apr 2004 19:29:47 -0000    1.9
> +++ src/WINNT/client_creds/NTMakefile    5 May 2004 12:28:01 -0000
> @@ -42,7 +42,7 @@
>
>  AFSDOBJS = \
>      $(OUT)\fs_utils.obj
> -   
> +
>  AFSAPPLIBOBJS= \
>      $(OUT)\checklist.obj \
>      $(OUT)\al_wizard.obj \
> @@ -90,19 +90,19 @@
>  CLIENT= ..\client_config
>
>  $(CLIENTOBJS): $(CLIENT)\$$(@B).cpp
> -    $(C2OBJ) -I$*(*D) $**
> +    $(C2OBJ) -I$(*D) $**
>
>  $(AFSAPPLIBOBJS): $(AFSAPPLIB)\$$(@B).cpp
> -    $(C2OBJ) -I$*(*D) $**
> +    $(C2OBJ) -I$(*D) $**
>
>  $(AFSDOBJS): $(AFSD)\$$(@B).c
> -    $(C2OBJ) -I$*(*D) $**
> +    $(C2OBJ) -I$(*D) $**
>
>  $(EXEOBJS): $$(@B).cpp
> -    $(C2OBJ) -I$*(*D) -I$(AFSAPPLIB) $**
> +    $(C2OBJ) -I$(*D) -I$(AFSAPPLIB) $**
>
>  $(EXECOBJS): $$(@B).c
> -    $(C2OBJ) -I$*(*D) -I$(AFSAPPLIB) $**
> +    $(C2OBJ) -I$(*D) -I$(AFSAPPLIB) $**
>
>  ############################################################################ 
>
>
> Index: src/WINNT/install/NSIS/OpenAFS.nsi
> ===================================================================
> RCS file: /cvs/openafs/src/WINNT/install/NSIS/OpenAFS.nsi,v
> retrieving revision 1.50
> diff -u -r1.50 OpenAFS.nsi
> --- src/WINNT/install/NSIS/OpenAFS.nsi    2 May 2004 22:09:22 -0000    
> 1.50
> +++ src/WINNT/install/NSIS/OpenAFS.nsi    5 May 2004 12:28:13 -0000
> @@ -53,7 +53,7 @@
>    OutFile "${AFS_DESTDIR}\WinInstall\OpenAFSforWindows-DEBUG.exe"
>  !endif
>    SilentInstall normal
> -  SetCompressor bzip2
> +  SetCompressor lzma
>    !define MUI_ICON "..\..\client_config\afs_config.ico"
>    !define MUI_UNICON "..\..\client_config\afs_config.ico"
>    !define AFS_COMPANY_NAME "OpenAFS"
>