Re: [PATCH v2 06/14] jbd2: replace ll_rw_block()

"Theodore Ts'o" <[email protected]> Mon, 5 Sep 2022 04:23:24 -0400

Newsgroups	gmane.comp.file-systems.reiserfs.general,gmane.comp.file-systems.ext4,gmane.linux.file-systems,gmane.linux.kernel,gmane.linux.cluster.redhat.cluster.devel,gmane.comp.file-systems.ocfs2.devel
Message-ID	<YxWx/[email protected]>

On Thu, Sep 01, 2022 at 09:34:57PM +0800, Zhang Yi wrote:
> ll_rw_block() is not safe for the sync read path because it cannot
> guarantee that submitting read IO if the buffer has been locked. We
> could get false positive EIO after wait_on_buffer() if the buffer has
> been locked by others. So stop using ll_rw_block() in
> journal_get_superblock(). We also switch to new bh_readahead_batch()
> for the buffer array readahead path.
> 
> Signed-off-by: Zhang Yi <[email protected]>

Thanks, looks good.

Reviewed-by: Theodore Ts'o <[email protected]>


					- Ted