Re: [PATCH v4 1/5] reiserfs: Add missing calls to reiserfs_security_free()
Mimi Zohar <[email protected]>
| Newsgroups | gmane.linux.kernel.lsm,gmane.comp.file-systems.reiserfs.general,gmane.linux.kernel,gmane.linux.kernel.stable |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 2022-11-10 at 10:46 +0100, Roberto Sassu wrote: > From: Roberto Sassu <[email protected]> > > Commit 57fe60df6241 ("reiserfs: add atomic addition of selinux attributes > during inode creation") defined reiserfs_security_free() to free the name > and value of a security xattr allocated by the active LSM through > security_old_inode_init_security(). However, this function is not called > in the reiserfs code. > > Thus, add a call to reiserfs_security_free() whenever > reiserfs_security_init() is called, and initialize value to NULL, to avoid > to call kfree() on an uninitialized pointer. > > Finally, remove the kfree() for the xattr name, as it is not allocated > anymore. > > Fixes: 57fe60df6241 ("reiserfs: add atomic addition of selinux attributes during inode creation") > Cc: [email protected] > Cc: Jeff Mahoney <[email protected]> > Cc: Tetsuo Handa <[email protected]> > Reported-by: Mimi Zohar <[email protected]> > Reported-by: Tetsuo Handa <[email protected]> > Signed-off-by: Roberto Sassu <[email protected]> Reviewed-by: Mimi Zohar <[email protected]>