Re: [PATCH 00/79] fs: new accessors for inode->i_ctime
Jeff Layton <[email protected]>
| Newsgroups | gmane.linux.cluster.redhat.cluster.devel,gmane.linux.uml.devel,gmane.linux.usb.general,gmane.linux.kernel,gmane.linux.kernel.mm,gmane.comp.file-systems.nilfs.user,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.ecryptfs.general,gmane.linux.ports.ppc64.devel,gmane.comp.file-systems.reiserfs.general,gmane.linux.file-systems.ntfs.devel,gmane.linux.file-systems.f2fs,gmane.linux.kernel.efi,gmane.linux.drivers.mtd,gmane.linux.drivers.rdma,gmane.linux.kernel.autofs,gmane.comp.file-systems.ceph.devel,gmane.linux.nfs,gmane.comp.file-systems.ext4,gmane.network.samba.internals,gmane.linux.network,gmane.linux.file-systems,gmane.linux.kernel.bpf,gmane.comp.file-systems.ocfs2.devel,gmane.linux.kernel.cifs,gmane.comp.security.apparmor,gmane.linux.file-systems.union,gmane.linux.kernel.lsm,gmane.linux.hardware.karma.devel,gmane.comp.file-systems.btrfs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton <[email protected]> wrote: > > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That will come later, as we convert individual > > filesystems to use multigrain timestamps. > > BTW, Linus has suggested to me that whenever a conccinelle script is used, > it should be included in the change log. > Ok, here's what I have. I note again that my usage of coccinelle is pretty primitive, so I ended up doing a fair bit of by-hand fixing after applying these. Given the way that this change is broken up into 77 patches by subsystem, to which changelogs should I add it? I could add it to the "infrastructure" patch, but that's the one where I _didn't_ use it. Maybe to patch #79 (the one that renames i_ctime)? ------------------------8<------------------------------ @@ expression inode; @@ - inode->i_ctime = current_time(inode) + inode_set_current_ctime(inode) @@ expression inode; @@ - inode->i_ctime = inode->i_mtime = current_time(inode) + inode->i_mtime = inode_set_current_ctime(inode) @@ struct inode *inode; expression value; @@ - inode->i_ctime = value; + inode_set_ctime(inode, value); @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_sec = val + inode_set_ctime_sec(inode, val) @@ struct inode *inode; expression val; @@ - inode->i_ctime.tv_nsec = val + inode_set_ctime_nsec(inode, val) @@ struct inode *inode; @@ - inode->i_ctime + inode_ctime_peek(inode)