Re: [PATCH][next] reiserfs: Replace one-element array with flexible-array member
Kees Cook <[email protected]>
| Newsgroups | gmane.comp.file-systems.reiserfs.general,gmane.linux.kernel |
|---|---|
| Message-ID | <202306211703.9AC418A@keescook> |
On Wed, Jun 21, 2023 at 04:43:54PM -0600, Gustavo A. R. Silva wrote: > One-element arrays are deprecated, and we are replacing them with flexible > array members instead. So, replace one-element array with flexible-array > member in direntry_uarea structure, and refactor the rest of the code, > accordingly. > > Worth mentioning is that before these changes, the original implementation > was returning two-too many bytes in function direntry_create_vi(): > > fs/reiserfs/item_ops.c:464: int size = sizeof(struct direntry_uarea); > ... > fs/reiserfs/item_ops.c-490- size += (dir_u->entry_count * sizeof(short)); > ... > fs/reiserfs/item_ops.c-517- return size; > > Link: https://github.com/KSPP/linux/issues/79 > Link: https://github.com/KSPP/linux/issues/290 > Signed-off-by: Gustavo A. R. Silva <[email protected]> Reviewed-by: Kees Cook <[email protected]> -- Kees Cook