Re: [PATCH v2 08/92] fs: new helper: simple_rename_timestamp
Jeff Layton <[email protected]>
| Newsgroups | gmane.linux.cluster.redhat.cluster.devel,gmane.linux.uml.devel,gmane.linux.usb.general,gmane.linux.kernel,gmane.linux.kernel.mm,gmane.comp.file-systems.nilfs.user,gmane.comp.file-systems.coda.general,gmane.comp.file-systems.ecryptfs.general,gmane.linux.ports.ppc64.devel,gmane.comp.file-systems.reiserfs.general,gmane.linux.file-systems.ntfs.devel,gmane.linux.file-systems.f2fs,gmane.linux.kernel.efi,gmane.linux.drivers.mtd,gmane.linux.drivers.rdma,gmane.linux.kernel.autofs,gmane.comp.file-systems.ceph.devel,gmane.linux.nfs,gmane.comp.file-systems.ext4,gmane.network.samba.internals,gmane.linux.network,gmane.linux.file-systems,gmane.linux.kernel.bpf,gmane.linux.kernel.cifs,gmane.comp.security.apparmor,gmane.linux.file-systems.union,gmane.linux.kernel.lsm,gmane.linux.hardware.karma.devel,gmane.comp.file-systems.btrfs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 2023-08-30 at 01:19 +0100, Al Viro wrote: > On Wed, Jul 05, 2023 at 02:58:11PM -0400, Jeff Layton wrote: > > > + * POSIX mandates that the old and new parent directories have their ctime and > > + * mtime updated, and that inodes of @old_dentry and @new_dentry (if any), have > > + * their ctime updated. > > APPLICATION USAGE > Some implementations mark for update the last file status change timestamp > of renamed files and some do not. Applications which make use of the > last file status change timestamp may behave differently with respect > to renamed files unless they are designed to allow for either behavior. > > So for children POSIX permits rather than mandates. Doesn't really matter; > Linux behaviour had been to touch ctime on children since way back, if > not since the very beginning. Mea culpa. You're quite correct. I'll plan to roll a small patch to update the comment over this function. Thanks! -- Jeff Layton <[email protected]>