[PATCH] reiserfs: fix null ptr deref in reiserfs_xattr_set
Edward Adam Davis <[email protected]> Wed, 3 Jan 2024 20:40:13 +0800
| Newsgroups | gmane.comp.file-systems.reiserfs.general,gmane.linux.file-systems,gmane.linux.kernel |
|---|---|
| Message-ID | <[email protected]> |
Before performing any xattr settings, it is necessary to first confirm that both xattr_root and priv_root are valid. Reported-and-tested-by: [email protected] Signed-off-by: Edward Adam Davis <[email protected] --- fs/reiserfs/xattr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/reiserfs/xattr.c b/fs/reiserfs/xattr.c index 998035a6388e..00fd8f747394 100644 --- a/fs/reiserfs/xattr.c +++ b/fs/reiserfs/xattr.c @@ -618,6 +618,9 @@ int reiserfs_xattr_set(struct inode *inode, const char *name, int error, error2; size_t jbegin_count = reiserfs_xattr_nblocks(inode, buffer_size); + if (!reiserfs_xattrs_initialized(inode->i_sb)) + return -EOPNOTSUPP; + /* Check before we start a transaction and then do nothing. */ if (!d_really_is_positive(REISERFS_SB(inode->i_sb)->priv_root)) return -EOPNOTSUPP; -- 2.43.0