Re: [PATCH 15/71] xfs: create refcount update intent log items
Christoph Hellwig <[email protected]>
| Newsgroups | gmane.comp.file-systems.xfs.general |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Sep 06, 2016 at 09:43:41AM -0700, Darrick J. Wong wrote: > <shrug> I'm relatively indifferent either way, though I noticed that > EFIs have a separate copy_format function in xfs_extfree_item.c which > reduces the amount of clutter in xfs_log_recover.c. It seemed more > neat to keep all the log item functions corralled within a separate > file rather than putting them in xfs_log_recover.c, so I maintained > that pattern for the rui/cui/bui items. The big difference with the EFI is that we had packing problems with them so we might have to do a few different conversions. > In a semi-related side note I've been toying with turning on LTO in > xfsprogs to see how much it shrinks all the XFS code. Code size goes > down considerably (repair shrinks by nearly 1MB!) but wow the > resulting tangle can be a PITA to debug. :( Yes. LTO is a nightmare for debugging. _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs