Re: [PATCH 07/71] xfs: define tracepoints for refcount btree activities
"Darrick J. Wong" <[email protected]>
| Newsgroups | gmane.comp.file-systems.xfs.general |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Sep 06, 2016 at 07:54:46AM -0700, Christoph Hellwig wrote:
> > +#ifndef XFS_REFCOUNT_IREC_PLACEHOLDER
> > +#define XFS_REFCOUNT_IREC_PLACEHOLDER
> > +/* Placeholder definition to avoid breaking bisectability. */
> > +struct xfs_refcount_irec {
> > + xfs_agblock_t rc_startblock; /* starting block number */
> > + xfs_extlen_t rc_blockcount; /* count of free blocks */
> > + xfs_nlink_t rc_refcount; /* number of inodes linked here */
> > +};
> > +#endif
>
> I didn't really understand the point earlier either - why can't
> you just merge the patch adding the tracepoints into that defining
> the structures and calling the tracepoints? That would avoid that
> whole exercise.
Originally I did it that way so my eyes wouldn't bleed every time I
looked at the follow-on patch, but you're right that these can be
consolidated now.
--D
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs