Re: [PATCH 16/71] xfs: log refcount intent items

On Thu, Sep 08, 2016 at 04:16:56PM -0700, Darrick J. Wong wrote:
> > Carfeul there - enums are not defined to have a fixed size and so
> > can change from compiler version to compiler version. IOWs, the
> > enum values can be written idirectly to an on-disk structure, but
> > the on-disk structure should not be using the enum as the type
> > definition for whatever gets stored on disk.
> 
> <nod>  I left the fields (and the #define flags) definitions alone,
> so it's only writing enum values indirectly into a fixed size (u32)
> variable on-disk.
> 
> i.e. I'm not using enums in the on-disk structure definitions.

now add a byte swap for the flags and everything should be fine.
The whole idea of architecture-dependent log items was a horrible
idea, and I still have hopes of fixing it eventually.

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs