Re: [PATCH] mm: remove unnecessary rcu_lock/unlock around radix_tree_tagged lockless function. The function queue_delayed_work is already protected with interrupts disabled, hence no need to add rcu_lock/unlock.
Dave Chinner <[email protected]> Mon, 26 Sep 2016 07:45:24 +1000
| Newsgroups | gmane.comp.file-systems.xfs.general |
|---|---|
| Message-ID | <20160925214524.GS340@dastard> |
On Mon, Sep 26, 2016 at 12:50:06AM +0530, Sudip Midya wrote: > Signed-off-by: Sudip Midya <[email protected]> > --- Patch format still needs work. The subject line should be short, the patch description should be in the body of the message, not the subject. Also, this is not a patch for the "mm" subsystem. Addressing the reason given for the change: the RCU lock is not actually protecting queue_delayed_work(), so while the code change may be OK, the reason given for removing it is not. So why is it safe to remove the rcu_read_lock()? Cheers, Dave. -- Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs