Re: libofx changes

On February 2, 2010 01:23:49 pm Yuri R wrote:
> The patch is attached.
> =

> Please note that I removed auto-generated files:
> =

> inc/libofx.h
> ofxconnect/cmdline.c
> ofxconnect/cmdline.h
> ofxdump/cmdline.c
> ofxdump/cmdline.h
> =

> My changes should not affect existing clients because I haven't changed
> existing data structures/classes (except OfxMainContainer that holds new
> containers).
> =

> My main worry is how I implemented linking of nested data structures,
> how this linking is reflected in the corresponding container classes,
> and how these containers are stored in OfxMainContainer.  Examples of
> linked data structures: OfxOptionData =3D> OfxSecurityData, OfxPosOptData
> =3D> OfxInvPosData.  I'm not sure if my implementation is in line with the
> library's original design.  Any feedback on this would be greatly
> appreciated.

Well, I hardly play with libofx anymore.  =


But generally speaking, as long as the code works, and the public api is =

consistent, I don't think anyone is going to be fussy for style.  The desig=
n =

of the library is rather antiquated anyway.


-- =

Benoit Gr=E9goire

---------------------------------------------------------------------------=
---