Re: AQ_CHECK_OS ( [SCM] libofx branch master updated. 7c8d1658bf2a9ad890f043854ccf995bd0ee44d2)

Dear Benoit,

this change has a problem:

Am Freitag, 13. Mai 2011 schrieb Benoit GrXXgoire:
> commit 55cf354edb49e2823fe3258deb80228cfd339577
> Author: Benoit Gr=C3=A9goire <[email protected]>
> Date:   Fri May 13 15:09:11 2011 -0400
> =

>     Apply patches by Bryan Donlan <[email protected]> (...)
>     -Remove bogus 'AQ_CHECK_OS' macro call from configure.in.

The autoconf macro AQ_CHECK_OS (defined in the manually shipped file m4/os.=
m4, =

added by Martin Preuss sometime earlier) defines the source code macro =

OS_WIN32 in <config.h> if the code is compiled on a windows platform. That =

macro is checked for in quite a number of places:

$ grep OS_WIN `find . -name '*.cpp'`
./lib/win32.cpp:#ifdef OS_WIN32
./lib/ofx_utilities.cpp:#ifdef OS_WIN32
./lib/ofx_utilities.cpp:#ifdef OS_WIN32
./lib/ofx_preproc.cpp:#ifdef OS_WIN32
./lib/ofx_preproc.cpp:#ifdef OS_WIN32
./lib/ofx_preproc.cpp:#ifdef OS_WIN32
./lib/ofx_preproc.cpp:#ifdef OS_WIN32
./lib/ofx_preproc.cpp:#ifdef OS_WIN32

I agree that this macro probably isn't the most effective solution to check =

for platform-specific things on windows. However, currently OS_WIN32 *is* =

being used. Removing AQ_CHECK_OS from configure.ac will break those places =

where it is used. Specifically, I'm quite sure after this change libofx won=
't =

work on windows anymore, even though it might still compile.

Can you please either add AQ_CHECK_OS into configure.ac again, or come up w=
ith =

a solution that really doesn't need those <config.h> macros anymore? Thanks.

Regards,

Christian

---------------------------------------------------------------------------=
---
Achieve unprecedented app performance and reliability
What every C/C++ and Fortran developer should know.
Learn how Intel has extended the reach of its next-generation tools
to help boost performance applications - inlcuding clusters.
http://p.sf.net/sfu/intel-dev2devmay