Re: segfault bug fix

On October 14, 2013 01:47:51 AM Martin Hosken wrote:
> Hi all,
> 
> I'm not sure of the best way to submit patches. But I enclose a few
> short ones inline.

Ideally, start yourself a github copy/fork.
You do that by signing into github and starting your own account and 
following the steps here:
https://help.github.com/articles/fork-a-repo

Once you have that, then you clone it to your computer:
git clone https://github.com/your_repo.... myfontforge

I find configuring "remotes" easier to patch the .git/config file manually, but 
that's just my personal preference. Here is some edits that can help you 
get started, but edit it to fit your needs - this may help... and you'll 
note I'm not on this list since it's my own config file ;-)
---.git/config---more-stuff-start---
[remote "upstream"]
	url = https://github.com/fontforge/fontforge.git
	fetch = +refs/heads/*:refs/remotes/upstream/*
[remote "aktado"]
	url = https://github.com/aktado/fontforge.git
	fetch = +refs/heads/*:refs/remotes/aktado/*
[remote "dmeranda"]
	url = https://github.com/dmeranda/fontforge.git
	fetch = +refs/heads/*:refs/remotes/dmeranda/*
[remote "mimaz"]
	url = https://github.com/mimaz/fontforge.git
	fetch = +refs/heads/*:refs/remotes/mimaz/*
[remote "monkeyiq"]
	url = https://github.com/monkeyiq/fontforge-fork
	fetch = +refs/heads/*:refs/remotes/monkeyiq/*
[remote "mpetroff"]
	url = https://github.com/mpetroff/fontforge.git
	fetch = +refs/heads/*:refs/remotes/mpetroff/*
[remote "mskala"]
	url = https://github.com/mskala/fontforge.git
	fetch = +refs/heads/*:refs/remotes/mskala/*
[remote "MihailJP"]
	url = https://github.com/MihailJP/fontforge.git
	fetch = +refs/heads/*:refs/remotes/MihailJP/*
[remote "blipvert"]
	url = https://github.com/blipvert/fontforge.git
	fetch = +refs/heads/*:refs/remotes/blipvert/*
[remote "jhps"]
	url = https://github.com/jhps/fontforge-fork.git
	fetch = +refs/heads/*:refs/remotes/jhps/*
---.git/config---more-stuff-end---

With the above edits, you can then add upstream to your copy....
git fetch upstream
git merge upstream/master

If you want to pull something from someone else:
git fetch monkeyiq

I'm using KDE, so I'm finding gitk rather nice as a GUI

When you've got a_patch/patches done:

git push origin

...then make a pull-request from your github webpage (shows-up when you're 
master has new stuff not on "upstream").

This makes it easier to do pull-requests by more than one maintainer.




> Things I did to get master building on precise. I'm not sure how many
> are strictly necessary. But I know we don't want to build osx on linux
> and some inc paths are needed for tests.

Added!  :-)

> And now to the interesting bug which handles a segfault, a key error and
> tidying up some scaffolding in python.c:

Which segfault?
Anything listed in github we're trying to vanquish (close some issues)?

------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from 
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk