Re: Collab code impact

On 3 March 2014 10:59, Ben Martin <[email protected]> wrote:

> Hi,
>   I'm always happy to try to minimize the impact of this code on the
> wider codebase. I've tried to minimize the current impact by making the
> function shells available as empty shells on non collab builds to avoid
> preprocessor guards and the like. The main area this has to have some
> hook into is the undo/redo stuff, but that should be fairly narrow.
>
>   I'll take another look at some stage to see if things can be narrowed
> down. Specific suggestions are always welcome :)
>

Empty functions cause compiler warnings. How about replacing them by
generic callbacks which are called if non-NULL? Are the hooks you'd need
useful for anything else? The code would be easier to understand if it
looked more like a general system and less like the random incursion of one
module into another (albeit for understandable reasons!).

-- 
http://rrt.sc3d.org

------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk

_______________________________________________
Fontforge-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel