Re: Run entire codebase through GNU Indent?

Daniel Kahn Gillmor <[email protected]> Fri, 11 Jul 2014 13:28:12 -0400

Newsgroups	gmane.comp.fonts.fontforge.devel
Message-ID	<[email protected]>

On 07/11/2014 12:53 PM, Felipe Sanches wrote:
> One can tag the git commit immediately before the one in which GNU indent
> was used and then people can git-blame at that commit if they are
> interested in tracking authorship of code changes implemented before that.
> 
> The major question here is: what is greater? (A) The benefit of code
> readability by having consistent indentation accross the whole codebase or
> (B) The git-blame issue?
> 
> I'd say B is a tolerable issue given that there is a known workaround (as I
> have just described above) and that A seems to be a good thing for the
> project in the long term.

It's also worth noting that git blame has a -w option, which is
documented as:

       -w
           Ignore whitespace when comparing the parent’s version and the
           child’s to find where the lines came from.

So at least in cases where GNU indent doesn't add or remove linebreaks,
people don't even need to take Felipe's workaround.

a codebase cleanup, ideally coupled with some mechanism to prevent
future drift from the chosen convention, will be healthier for the
project in the long term, and the sooner it's done the better.

rip off the bandage :)

	--dkg

------------------------------------------------------------------------------

_______________________________________________
Fontforge-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/fontforge-devel

signature.asc (application/pgp-signature, 949 B)